glibmm: add v2.78.0, drop static build support #22023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2023
conan-center-bot
added
Failed
Missing dependencies
This comment has been minimized.
This comment has been minimized.
|
Regenerating missing binaries now |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
conan-center-bot
removed
Failed
stale
Missing dependencies
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
jwillikers
approved these changes
Mar 25, 2024
AbrilRBS
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for static builds is quite broken out of the box for this library and the amount of patching required to add support for it seems excessive to me and are a maintenance headache. Especially the code-level patches, in light of the discussion at #17338.
I would have kept the excisting patches for older versions, but I don't think I can delete the
sharedandfPICoptions selectively without conflicting withpackage_type.